Skip to content

fix(testing-library): wrap renderPage in act #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

upupming
Copy link
Collaborator

Summary

Wrap the main thread renderPage in preact act.

It will ensure all the code inside renderPage and all effects are executed.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: 712a3ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lynx-js/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Jun 26, 2025

CodSpeed Performance Report

Merging #1170 will not alter performance

Comparing upupming:fix/testing-library-main (712a3ca) with main (360050f)

Summary

✅ 10 untouched benchmarks

Copy link

relativeci bot commented Jun 26, 2025

React Example

#2483 Bundle Size — 234.7KiB (0%).

712a3ca(current) vs 360050f main#2470(baseline)

Bundle metrics  no changes
                 Current
#2483
     Baseline
#2470
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 153 153
No change  Duplicate Modules 61 61
No change  Duplicate Code 45.85% 45.85%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2483
     Baseline
#2470
No change  IMG 145.76KiB 145.76KiB
No change  Other 88.94KiB 88.94KiB

Bundle analysis reportBranch upupming:fix/testing-library-mai...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Jun 26, 2025

Web Explorer

#2474 Bundle Size — 259.21KiB (0%).

712a3ca(current) vs 360050f main#2461(baseline)

Bundle metrics  Change 1 change
                 Current
#2474
     Baseline
#2461
No change  Initial JS 140.64KiB 140.64KiB
No change  Initial CSS 31.82KiB 31.82KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 4 4
No change  Assets 4 4
Change  Modules 205(-0.97%) 207
No change  Duplicate Modules 16 16
No change  Duplicate Code 3.61% 3.61%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2474
     Baseline
#2461
No change  JS 227.39KiB 227.39KiB
No change  CSS 31.82KiB 31.82KiB

Bundle analysis reportBranch upupming:fix/testing-library-mai...Project dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant