-
Notifications
You must be signed in to change notification settings - Fork 113
fix(react): avoid manipulate __pendingListUpdates
unless SnapshotInstance tree is changed
#1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c334f16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #1201 will not alter performanceComparing Summary
|
Web Explorer#2551 Bundle Size — 259.52KiB (0%).c334f16(current) vs ae3a1a8 main#2540(baseline) Bundle metrics
Bundle size by type
|
Current #2551 |
Baseline #2540 |
|
---|---|---|
227.7KiB |
227.7KiB |
|
31.82KiB |
31.82KiB |
Bundle analysis report Branch hzy:p/hzy/list-perf-0 Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#2560 Bundle Size — 234.92KiB (+0.1%).c334f16(current) vs ae3a1a8 main#2549(baseline) Bundle metrics
Bundle size by type
Bundle analysis report Branch hzy:p/hzy/list-perf-0 Project dashboard Generated by RelativeCI Documentation Report issue |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
…stance tree is changed We make `__pendingListUpdates.values` nullable, and set it to null to indicate manipulating it should be avoided, in the following scenarios: 1. setAttribute when hydrate 2. setAttribute when ensureElements
Co-authored-by: BitterGourd <[email protected]> Signed-off-by: Zhiyuan Hong <[email protected]>
We make
__pendingListUpdates.values
nullable, and set it to null to indicate manipulating it should be avoided, in the following scenarios:Summary
Checklist