-
Notifications
You must be signed in to change notification settings - Fork 113
feat(react/runtime): integrate with preact/debug
#1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8e0c31a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Qingyu Wang <[email protected]>
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
CodSpeed Performance ReportMerging #1222 will not alter performanceComparing Summary
|
React Example#2568 Bundle Size — 234.7KiB (0%).8e0c31a(current) vs ae3a1a8 main#2549(baseline) Bundle metrics
Bundle size by type
|
Current #2568 |
Baseline #2549 |
|
---|---|---|
145.76KiB |
145.76KiB |
|
88.94KiB |
88.94KiB |
Bundle analysis report Branch colinaaa:colin/0704/preact-debug Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#2559 Bundle Size — 259.52KiB (0%).8e0c31a(current) vs ae3a1a8 main#2540(baseline) Bundle metrics
|
Current #2559 |
Baseline #2540 |
|
---|---|---|
140.94KiB |
140.94KiB |
|
31.82KiB |
31.82KiB |
|
0% |
0% |
|
4 |
4 |
|
4 |
4 |
|
210 |
210 |
|
17 |
17 |
|
4.15% |
4.15% |
|
4 |
4 |
|
0 |
0 |
Bundle size by type no changes
Current #2559 |
Baseline #2540 |
|
---|---|---|
227.7KiB |
227.7KiB |
|
31.82KiB |
31.82KiB |
Bundle analysis report Branch colinaaa:colin/0704/preact-debug Project dashboard
Generated by RelativeCI Documentation Report issue
Summary
This patch add a
nodeType
property forroot
which make@lynx-js/react
work withpreact/debug
.Corresponding tests for supported
preact/debug
checks have been added.Note
The tests are divided into separate files because
preact/debug
stores the component stack in memory, which could lead to incorrect behavior if the initial render fails.Checklist