Skip to content

feat(react/runtime): integrate with preact/debug #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Jul 4, 2025

Summary

This patch add a nodeType property for root which make @lynx-js/react work with preact/debug.

Corresponding tests for supported preact/debug checks have been added.

Note

The tests are divided into separate files because preact/debug stores the component stack in memory, which could lead to incorrect behavior if the initial render fails.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 8e0c31a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lynx-js/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 4, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2612 1 2611 46
View the top 1 failed test(s) by shortest run time
react.spec.ts::reactlynx3 tests › basic › basic-mts-run-on-main-thread
Stack Traces | 150s run time
react.spec.ts:404:5 basic-mts-run-on-main-thread

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #1222 will not alter performance

Comparing colinaaa:colin/0704/preact-debug (8e0c31a) with main (5a9b38b)

Summary

✅ 10 untouched benchmarks

Copy link

relativeci bot commented Jul 4, 2025

React Example

#2568 Bundle Size — 234.7KiB (0%).

8e0c31a(current) vs ae3a1a8 main#2549(baseline)

Bundle metrics  Change 1 change
                 Current
#2568
     Baseline
#2549
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 153 153
No change  Duplicate Modules 61 61
Change  Duplicate Code 45.86%(+0.02%) 45.85%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2568
     Baseline
#2549
No change  IMG 145.76KiB 145.76KiB
No change  Other 88.94KiB 88.94KiB

Bundle analysis reportBranch colinaaa:colin/0704/preact-debugProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Jul 4, 2025

Web Explorer

#2559 Bundle Size — 259.52KiB (0%).

8e0c31a(current) vs ae3a1a8 main#2540(baseline)

Bundle metrics  no changes
                 Current
#2559
     Baseline
#2540
No change  Initial JS 140.94KiB 140.94KiB
No change  Initial CSS 31.82KiB 31.82KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 4 4
No change  Assets 4 4
No change  Modules 210 210
No change  Duplicate Modules 17 17
No change  Duplicate Code 4.15% 4.15%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2559
     Baseline
#2540
No change  JS 227.7KiB 227.7KiB
No change  CSS 31.82KiB 31.82KiB

Bundle analysis reportBranch colinaaa:colin/0704/preact-debugProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant