Skip to content

refactor(react/refresh): replace esbuild with rslib #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Jul 4, 2025

Summary

Replace esbuild --bundle src/index.ts --outfile=dist/index.js --external:@lynx-js/react --define:self=globalThis --format=esm --alias:preact=@lynx-js/react/internal --alias:preact/hooks=@lynx-js/react with Rslib.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

changeset-bot bot commented Jul 4, 2025

⚠️ No Changeset found

Latest commit: 2bcde73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colinaaa colinaaa changed the title refactor(react/refresh): replace ESBuild with Rslib refactor(react/refresh): replace esbuild with rslib Jul 4, 2025
Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #1223 will not alter performance

Comparing colinaaa:colin/0705/refresh-rslib (2bcde73) with main (ae3a1a8)

Summary

✅ 10 untouched benchmarks

Copy link

relativeci bot commented Jul 4, 2025

React Example

#2569 Bundle Size — 234.7KiB (0%).

2bcde73(current) vs ae3a1a8 main#2549(baseline)

Bundle metrics  no changes
                 Current
#2569
     Baseline
#2549
No change  Initial JS 0B 0B
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 0 0
No change  Assets 4 4
No change  Modules 153 153
No change  Duplicate Modules 61 61
No change  Duplicate Code 45.85% 45.85%
No change  Packages 2 2
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2569
     Baseline
#2549
No change  IMG 145.76KiB 145.76KiB
No change  Other 88.94KiB 88.94KiB

Bundle analysis reportBranch colinaaa:colin/0705/refresh-rsli...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Jul 4, 2025

Web Explorer

#2560 Bundle Size — 259.52KiB (0%).

2bcde73(current) vs ae3a1a8 main#2540(baseline)

Bundle metrics  Change 2 changes
                 Current
#2560
     Baseline
#2540
No change  Initial JS 140.94KiB 140.94KiB
No change  Initial CSS 31.82KiB 31.82KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 4 4
No change  Assets 4 4
Change  Modules 208(-0.95%) 210
No change  Duplicate Modules 17 17
Change  Duplicate Code 4.16%(+0.24%) 4.15%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#2560
     Baseline
#2540
No change  JS 227.7KiB 227.7KiB
No change  CSS 31.82KiB 31.82KiB

Bundle analysis reportBranch colinaaa:colin/0705/refresh-rsli...Project dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant