Skip to content

feat: add convert nat-domain-name to nat-ip at the start of neko #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cr34t1ngH0p3
Copy link

Hi, I read this #402 and #247 . In my case it was already helpful if at least at the start I could provide some domainname. Please provide some feedback if it is also useful for you. :)

Best

@m1k1o
Copy link
Owner

m1k1o commented Mar 23, 2025

Looks good, but NAT1TO1 in Pion WebRTC is a list of two element: IPv4 and IPv6. So adding multiple domains and resolving them would also need this fix: #47

You could argue that user could add two domains, one that has only A record and another that has only AAAA record, but the whole option seems very counter-intuitive currently and would need a proper refactor with the support of multiple IPs/hostnames.

@Cr34t1ngH0p3
Copy link
Author

Looks good, but NAT1TO1 in Pion WebRTC is a list of two element: IPv4 and IPv6. So adding multiple domains and resolving them would also need this fix: #47

You could argue that user could add two domains, one that has only A record and another that has only AAAA record, but the whole option seems very counter-intuitive currently and would need a proper refactor with the support of multiple IPs/hostnames.

Hey, thank you. But tbh, I am not understanding the issue 100%. Does multiple IPs end in an issue, or the combination of IP4 and IP6? And if I read domain names and transfer them to IPs, does that change anything at this issue?

@m1k1o
Copy link
Owner

m1k1o commented Mar 24, 2025

I would work for the first domain only. So the PR is correct, your implementation is actually good. Its just the underlying feature that is confusing. And my idea was, when we are already touching it, it could be refactored entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants