Skip to content

fix: handle ad_break_id key in the ad Summary event #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mansi-mParticle merged 2 commits into from
Jun 11, 2025
Merged

fix: handle ad_break_id key in the ad Summary event #71

Mansi-mParticle merged 2 commits into from
Jun 11, 2025

Conversation

@Mansi-mParticle
Copy link
Contributor

@Mansi-mParticle Mansi-mParticle commented May 22, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This PR adds the ad_break_id to the ad_summary event. It was missing before.

Testing Plan

  • Tested it with the sample app and here’s a screenshot of the live stream.
    Before :
Screenshot 2025-06-11 at 5 33 31 PM

After :
Screenshot 2025-05-22 at 4 11 54 PM

Reference Issue

rmi22186
rmi22186 reviewed May 27, 2025
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can you add a test?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mmustafa-tse
Copy link
Contributor

mmustafa-tse commented Jun 11, 2025

LGTM

@Mansi-mParticle Mansi-mParticle merged commit 228a831 into main Jun 11, 2025
4 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-7264-handle-ad_break_id-key branch June 11, 2025 21:35
mparticle-automation added a commit that referenced this pull request Jun 12, 2025
@mparticle-automation
chore: 1.5.6 (release)
4040469 
## [1.5.6](v1.5.5...v1.5.6) (2025-06-12)

### Bug Fixes

* Correct the mapping of the mediaContentId key in the segment summary event ([#72](#72)) ([dad43eb](dad43eb))
* handle ad_break_id key in the ad Summary event ([#71](#71)) ([228a831](228a831))
@mparticle-automation
Copy link
Collaborator

mparticle-automation commented Jun 12, 2025

🎉 This PR is included in version 1.5.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 left review comments

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

+1 more reviewer

@mmustafa-tse mmustafa-tse mmustafa-tse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mansi-mParticle @mmustafa-tse @mparticle-automation @rmi22186