fix: adjust ad break exclusion logic#76
Merged
Mansi-mParticle merged 4 commits intomainfrom Dec 12, 2025
Merged
Conversation
thomson-t
reviewed
Nov 19, 2025
Member
|
I think the following test makes sense to ensure user pausing and ad break ending is correctly ensuring contentTime is calculated and excluding ad breaks. The scenario is let's say you are watching a youtube video and mid ad, a user pauses, then the ad break ends (perhaps the "skip" button is shown and the user clicks it, creating an ad break end). |
rmi22186
reviewed
Dec 8, 2025
|
rmi22186
approved these changes
Dec 8, 2025
samdozor
approved these changes
Dec 11, 2025
mparticle-automation
added a commit
that referenced
this pull request
Dec 12, 2025
## [1.7.0](v1.6.0...v1.7.0) (2025-12-12) ### Features * Update Media Content Time Spent Calculations with Ad Breaks ([#74](#74)) ([c455557](c455557)) ### Bug Fixes * adjust ad break exclusion logic ([#76](#76)) ([84b1493](84b1493)) ### Updates & Maintenance * Migrate from OSSRH to Central Publishing Portal ([#75](#75)) ([ac8de37](ac8de37))
Collaborator
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Instructions
Summary
Updated boolean flag usage for clarity.
Test cases modified to remove flaky timing assertions and ensure correctness.
Testing Plan
Reference Issue