Skip to content

fix: previous Google ad Id from being null on cold launch #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix: previous Google ad Id from being null on cold launch #518

merged 3 commits into from
Nov 14, 2024

Conversation

Mansi-mParticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Fix a bug where the previous Google app ID is null when the app is relaunched. This happened because the app ID was stored when the app paused; now, the code has been moved to when the app is in the foreground.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app and Executed unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

einsteinx2
einsteinx2 suggested changes Nov 6, 2024
View reviewed changes
einsteinx2
einsteinx2 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mansi-mParticle Mansi-mParticle merged commit fa9b79b into development Nov 14, 2024
22 of 23 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-6830-app-id-null branch November 14, 2024 00:31
Mansi-mParticle added a commit that referenced this pull request Feb 4, 2025
@Mansi-mParticle
fix: previous Google ad Id from being null on cold launch (#518)
9f7295f
Mansi-mParticle added a commit that referenced this pull request Feb 25, 2025
@Mansi-mParticle
fix: previous Google ad Id from being null on cold launch (#518)
81312a3
@Mansi-mParticle Mansi-mParticle mentioned this pull request Feb 25, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@samdozor samdozor Awaiting requested review from samdozor

@rmi22186 rmi22186 Awaiting requested review from rmi22186

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mansi-mParticle @einsteinx2