Skip to content

refactor: Migrate Internal messages package classes to kotlin #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2024
Merged

refactor: Migrate Internal messages package classes to kotlin #521

merged 4 commits into from
Nov 25, 2024

Conversation

Mansi-mParticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Migrate internal messages package classes BaseMPMessage and BaseMPMessageBuilder class and to Kotlin.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample application and ran the unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

einsteinx2
einsteinx2 suggested changes Nov 22, 2024
View reviewed changes
@einsteinx2 einsteinx2 merged commit 0a4d64b into blackout-2024 Nov 25, 2024
21 of 23 checks passed
@einsteinx2 einsteinx2 deleted the refactor/SQDSDKS-6705-message-class branch November 25, 2024 19:22
Mansi-mParticle added a commit that referenced this pull request Feb 4, 2025
@Mansi-mParticle
refactor: Migrate Internal messages package classes to kotlin (#521)
26eddd2 
* refactor: Migrate Internal messages package classes to kotlin

* add support for kotlin classes

* address review comments

* Refactor code to use functional style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@rmi22186 rmi22186 Awaiting requested review from rmi22186

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mansi-mParticle @einsteinx2