refactor: Migrate Internal DeviceAttributes class to kotlin #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
suggested changes
Dec 4, 2024
android-core/src/main/java/com/mparticle/internal/DeviceAttributes.kt
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/DeviceAttributes.kt
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/DeviceAttributes.kt
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/DeviceAttributes.kt
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/DeviceAttributes.kt
Outdated
Show resolved
Hide resolved
|
|
||
| try { | ||
| val mParticle = MParticle.getInstance() | ||
| if (mParticle != null) { |
There was a problem hiding this comment.
We can't use let here because, up until line 275, we'd have to check for null on every line if we did.
android-core/src/main/java/com/mparticle/internal/DeviceAttributes.kt
Outdated
Show resolved
Hide resolved
einsteinx2
approved these changes
Dec 4, 2024
Mansi-mParticle
deleted the
refactor/SQDSDKS-6711-DeviceAttributes-class
branch
Mansi-mParticle
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)