Skip to content

fix: Add @NonNull and @Nullable annotations to execute method parameters #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

fix: Add @NonNull and @Nullable annotations to execute method parameters #579

merged 2 commits into from
Jun 9, 2025

Conversation

Mansi-mParticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This PR adds the @NonNull and @Nullable annotations to execute method parameters. This update helps make the method's expectations clearer and improves null-safety in the code.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from rmi22186 June 5, 2025 21:40
@Mansi-mParticle Mansi-mParticle merged commit 9089098 into development Jun 9, 2025
24 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/annotation_for_execute_method branch June 9, 2025 19:19
mparticle-automation added a commit that referenced this pull request Jun 9, 2025
@mparticle-automation
chore: 5.65.0 (release)
6243d3c 
## [5.65.0](v5.64.0...v5.65.0) (2025-06-09)

### Features

* Add sandbox mode to attributes ([#559](#559)) ([cbccd13](cbccd13))

### Bug Fixes

* Add @nonnull and @nullable annotations to execute method parameters ([#579](#579)) ([9089098](9089098))
* add Rokt dimensions layout to show embedded placements correctly ([#580](#580)) ([9d6813c](9d6813c))

### Updates & Maintenance

* Update submodules ([4ed38b5](4ed38b5))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mansi-mParticle @mparticle-automation @rmi22186