Skip to content

fix: ensure user attributes are applied before proceeding with Rokt execution#585

Merged
Mansi-mParticle merged 1 commit intodevelopmentfrom
fix/SQDSDKS-7406-make-setuser-async
Jun 17, 2025
Merged

fix: ensure user attributes are applied before proceeding with Rokt execution#585
Mansi-mParticle merged 1 commit intodevelopmentfrom
fix/SQDSDKS-7406-make-setuser-async

Conversation

@Mansi-mParticle
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle commented Jun 16, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This PR update makes sure that user attributes are fully saved before moving to the next step.
    It uses a callback with getUserAttributes to wait until the data is ready.
    This helps avoid problems where Rokt tries to use user info before it's updated.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 requested review from jamesnrokt and thomson-t June 16, 2025 23:15
rmi22186
rmi22186 requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit

@Mansi-mParticle Mansi-mParticle force-pushed the fix/SQDSDKS-7406-make-setuser-async branch from b0b4ff0 to 41014f2 Compare June 17, 2025 13:56
@Mansi-mParticle Mansi-mParticle requested a review from rmi22186 June 17, 2025 13:58
@Mansi-mParticle Mansi-mParticle merged commit df0450e into development Jun 17, 2025
69 of 77 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-7406-make-setuser-async branch June 17, 2025 20:06
mparticle-automation added a commit that referenced this pull request Jun 17, 2025
@mparticle-automation
chore: 5.69.0 (release)
dcd5815 
## [5.69.0](v5.68.0...v5.69.0) (2025-06-17)

### Features

* Always set the wrapperSdkVersion in KitManager ([#584](#584)) ([a473157](a473157))

### Bug Fixes

* ensure user attributes are applied before proceeding with Rokt execution ([#585](#585)) ([df0450e](df0450e))
@mparticle-automation
Copy link
Collaborator

mparticle-automation commented Jun 17, 2025

🎉 This PR is included in version 5.69.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

@thomson-t thomson-t Awaiting requested review from thomson-t

@jamesnrokt jamesnrokt Awaiting requested review from jamesnrokt

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mansi-mParticle @mparticle-automation @rmi22186