Skip to content

feat: SQDSDKS-7420 update select placements #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jamesnrokt
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Extract Rokt to separate Kotlin class ready for Kotlin Flow usage
  • selectPlacements - rename placeholders param to embeddedViews
  • selectPlacements - rename viewName to identifier

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

) {

@JvmOverloads
fun selectPlacements(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some jsvadoc for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not added or updated JavaDocs just yet as these are currently on Google Docs so we can easily align both platforms when finalised

jamesnrokt and others added 8 commits June 17, 2025 15:29
Often getting error:

com.android.ddmlib.InstallException: INSTALL_FAILED_UPDATE_INCOMPATIBLE: Package com.mparticle.testutils.test signatures do not match previously installed version; ignoring!

Adding explicit uninstall
./gradlew connectedCheck --stacktrace
AND
./gradlew :android-core:cAT :android-kit-base:cAT

Share
:testutils:packageDebugAndroidTest
:testutils:connectedDebugAndroidTest
:testutils:connectedAndroidTest

Which may be causing:
Failed to install APK(s): /home/runner/work/mparticle-android-sdk/mparticle-android-sdk/android-core/build/outputs/apk/androidTest/debug/android-core-debug-androidTest.apk
INSTALL_FAILED_UPDATE_INCOMPATIBLE: Package com.mparticle.test signatures do not match previously installed version; ignoring!
com.android.ddmlib.InstallException: INSTALL_FAILED_UPDATE_INCOMPATIBLE: Package com.mparticle.test signatures do not match previously installed version; ignoring!
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle merged commit e583057 into development Jun 18, 2025
45 of 50 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/SQDSDKS-7420-update-select-placements branch June 18, 2025 15:25
mparticle-automation added a commit that referenced this pull request Jun 23, 2025
## [5.70.0](v5.69.0...v5.70.0) (2025-06-23)

### Features

* Add support for the fontFilePathMap ([#589](#589)) ([71cd132](71cd132))
* SQDSDKS-7420 update select placements ([#586](#586)) ([e583057](e583057))
* SQDSDKS-7422 - Add all Rokt events ([#587](#587)) ([2487f70](2487f70))

### Bug Fixes

* Include missing overridesSubdirectory flag in networkOptions for domain mapping ([#588](#588)) ([88c73b8](88c73b8))

### Updates & Maintenance

* Update submodules ([4429471](4429471))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants