Skip to content

feat: SQDSDKS-7422 - Add all Rokt events #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 20, 2025
Merged

feat: SQDSDKS-7422 - Add all Rokt events #587

merged 14 commits into from
Jun 20, 2025

Conversation

jamesnrokt
Copy link
Collaborator

@jamesnrokt jamesnrokt commented Jun 17, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add all Rokt events
  • FirstPositiveResponse only emits a placementId and not fulfilment object as this is deprecated
  • Flow wraps the Rokt SDK

Testing Plan

  • Was this tested locally? If not, explain why.
  • Published locally along with corresponding Kit implementation
  • Tested in local testing app to verify events are emitted correctly
Screenshot 2025-06-20 at 12 01 17 pm

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 requested a review from Mansi-mParticle June 17, 2025 13:13
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-7422-add-Rokt-Events branch from 1179a33 to 43507c9 Compare June 19, 2025 17:33
Mansi-mParticle
Mansi-mParticle approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with sample App and LGTM

@Mansi-mParticle Mansi-mParticle merged commit 2487f70 into development Jun 20, 2025
41 of 50 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/SQDSDKS-7422-add-Rokt-Events branch June 20, 2025 19:31
mparticle-automation added a commit that referenced this pull request Jun 23, 2025
@mparticle-automation
chore: 5.70.0 (release)
7ea68cc 
## [5.70.0](v5.69.0...v5.70.0) (2025-06-23)

### Features

* Add support for the fontFilePathMap ([#589](#589)) ([71cd132](71cd132))
* SQDSDKS-7420 update select placements ([#586](#586)) ([e583057](e583057))
* SQDSDKS-7422 - Add all Rokt events ([#587](#587)) ([2487f70](2487f70))

### Bug Fixes

* Include missing overridesSubdirectory flag in networkOptions for domain mapping ([#588](#588)) ([88c73b8](88c73b8))

### Updates & Maintenance

* Update submodules ([4429471](4429471))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mansi-mParticle Mansi-mParticle Mansi-mParticle approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesnrokt @mparticle-automation @Mansi-mParticle