fix: Include missing overridesSubdirectory flag in networkOptions for domain mapping #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonStalnaker
approved these changes
Jun 19, 2025
mparticle-automation
added a commit
that referenced
this pull request
Jun 23, 2025
## [5.70.0](v5.69.0...v5.70.0) (2025-06-23) ### Features * Add support for the fontFilePathMap ([#589](#589)) ([71cd132](71cd132)) * SQDSDKS-7420 update select placements ([#586](#586)) ([e583057](e583057)) * SQDSDKS-7422 - Add all Rokt events ([#587](#587)) ([2487f70](2487f70)) ### Bug Fixes * Include missing overridesSubdirectory flag in networkOptions for domain mapping ([#588](#588)) ([88c73b8](88c73b8)) ### Updates & Maintenance * Update submodules ([4429471](4429471))
|
🎉 This PR is included in version 5.70.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
When we implemented workspace switching, we added an "uploaded settings" option under networkOptions. However, the overridesSubdirectory field was missing from the networkOptions JSON, so it always defaulted to false.
As a result, when domain mapping required overridesSubdirectory to be true, it caused issues. This PR adds that missing field to prevent those problems.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)