Skip to content

refactor: Port MPDevice to Swift #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

BrandonStalnaker
Copy link
Collaborator

Summary

  • Refactored MPDevice to Swift

Testing Plan

  • Tested in sample app and unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Feb 6, 2025
@BrandonStalnaker BrandonStalnaker force-pushed the refactor/7023-Swift-port-MPDevice branch 5 times, most recently from 8aa315a to dc6f9df Compare February 6, 2025 19:08
@BrandonStalnaker BrandonStalnaker force-pushed the refactor/7023-Swift-port-MPDevice branch from dc6f9df to 84b6014 Compare February 6, 2025 19:27
@einsteinx2
Copy link
Contributor

I don't have access to approve, but reviewed over Zoom and this looks good to go.

Copy link

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben has already reviewed this code via zoom call , so it's now approved.

@BrandonStalnaker BrandonStalnaker merged commit 0fda347 into development Feb 11, 2025
12 checks passed
@BrandonStalnaker BrandonStalnaker deleted the refactor/7023-Swift-port-MPDevice branch February 11, 2025 15:30
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.27.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants