Skip to content

fix: Issue when setting Identity Attributes to nil #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: Issue when setting Identity Attributes to nil #336

merged 1 commit into from
Mar 18, 2025

Conversation

BrandonStalnaker
Copy link
Collaborator

Summary

  • Setting identity to nil in an identity request was causing a crash once it was reaching swift code

Testing Plan

  • Tested locally and through unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Mar 18, 2025
rmi22186
rmi22186 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Hopped on with Brandon to E2E test using old code to repro the issue, then using the new code, the sdk does not crash because Swift gets a nil value instead of NSNull

@BrandonStalnaker BrandonStalnaker merged commit 9a48cdd into development Mar 18, 2025
10 of 12 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/SQDSDKS-7144-Error-On-Setting-Identity-To-Nil branch March 18, 2025 18:32
mparticle-automation added a commit that referenced this pull request Mar 19, 2025
@mparticle-automation
chore(release): 8.28.0 [skip ci]
9610239 
# [8.28.0](v8.27.5...v8.28.0) (2025-03-19)

### Bug Fixes

* Issue when setting Identity Attributes to nil ([#336](#336)) ([9a48cdd](9a48cdd))

### Features

* implement audience logic ([#330](#330)) ([3b9ad82](3b9ad82))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@Mansi-mParticle Mansi-mParticle Awaiting requested review from Mansi-mParticle

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @mparticle-automation @rmi22186