Update copy.h #633
Draft
Update copy.h #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check available destination space before copy
madMAx43v3r
reviewed
Jun 22, 2021
include/chia/copy.h
Outdated
| #include <cstdio> | ||
| #include <cstdint> | ||
|
|
||
| #include <filesystem> |
There was a problem hiding this comment.
that has created many problems before, gotta souround all of it with #ifdef __linux__
There was a problem hiding this comment.
thanks, no real programming experience so forgive my terrible coding...
madMAx43v3r
requested changes
Jun 23, 2021
include/chia/copy.h
Outdated
| uint64_t copy_file(const std::string& src_path, const std::string& dst_path) | ||
| { | ||
| #ifdef __linux__ | ||
| int plotsize = 109000000000 |
There was a problem hiding this comment.
are you sure that number fits into an int lol
you need uint64_t here
There was a problem hiding this comment.
yes I was wondering about that! I guess it would be better to get the real size value but just put a rough value for now
There was a problem hiding this comment.
it's not a constant anyways, all good
added 4 commits
June 23, 2021 21:15
add room for alternate destination directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check available destination space before copy