Orchestrator: Fixes Workers #691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra into fix/multiple-minors
prkpndy
reviewed
Jul 5, 2025
Mohiiit
reviewed
Jul 6, 2025
Member
Mohiiit
left a comment
Mohiiit
left a comment
There was a problem hiding this comment.
can you clarify the difference between context implementation and the trigger implementation here? I see it's been used interchangeably or maybe I am missing something and do we really need that segregation?
Co-authored-by: Mohit Dhattarwal <[email protected]>
Mohiiit
reviewed
Jul 9, 2025
Trantorian1
approved these changes
Jul 10, 2025
Contributor
Trantorian1
left a comment
Trantorian1
left a comment
There was a problem hiding this comment.
From my limited experience with orchestrator, lgtm 👌
orchestrator/src/worker/event_handler/triggers/data_submission.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+173
to
+176
| pub struct ProcessingContext { | ||
| pub config: Arc<Config>, | ||
| pub earliest_failed_block: Option<u64>, | ||
| } |
Contributor
There was a problem hiding this comment.
madara/orchestrator/src/worker/event_handler/triggers/data_submission.rs
Lines 161 to 164 in 1e2a427
Co-authored-by: Trantorian1 <[email protected]>
Co-authored-by: Trantorian1 <[email protected]>
Mohiiit
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #590: Optimize Orchestrator Chain Settlement Logic
Problem
The Orchestrator currently halts the entire chain settlement process when any job reaches
FailedorVerification Timeoutstatus, leading to inefficient processing and unnecessary blocking of independent operations.Current problematic behavior:
StateTransitionfor block 5 is halted whenSnosRunfor block 10 fails)Solution
This PR optimizes the worker logic to continue processing independent jobs even when unrelated jobs fail, improving overall system resilience and throughput.