Feature/add no reorg #822
Merged
Feature/add no reorg #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
apoorvsadana
left a comment
apoorvsadana
left a comment
There was a problem hiding this comment.
let's discuss on the standup regarding how we can test this once!
madara/node/src/cli/l2.rs
Outdated
| /// the node will stop with an error instead of performing a reorg. This is useful for | ||
| /// operators who want to manually handle chain divergences. | ||
| #[clap(env = "MADARA_NO_REORG", long, default_value_t = true)] | ||
| pub no_reorg: bool, |
Contributor
There was a problem hiding this comment.
Suggested change
| pub no_reorg: bool, | |
| pub disable_reorg: bool, |
heemankv
reviewed
Oct 31, 2025
Contributor
heemankv
left a comment
heemankv
left a comment
There was a problem hiding this comment.
Please change no_reorg to disable_reorg
Also have we tested that the full node is able to sync even after one of the blocks had mismatched, I think we might also have to add disable_all_verifications(true) in l2.rs
So that this block could continue, Let's test and discuss
|
|
||
| // Check if reorg is disabled | ||
| if self.no_reorg { | ||
| tracing::error!("❌ REORG DETECTED but --no-reorg flag is enabled!"); |
Contributor
There was a problem hiding this comment.
nitpick : Let's re-write -> --no-reorg flag
to Reorganisation is explicitly denied by config or something that suite you better maybe
Contributor
There was a problem hiding this comment.
disagree! previous message was more specific, --no-reorg flag disabled reorging
| tracing::error!(" Incoming parent hash: {:#x}", incoming_parent_hash); | ||
| tracing::error!(""); | ||
| tracing::error!("⚠️ Divergent state detected - the local chain has diverged from the upstream chain."); | ||
| tracing::error!("⚠️ Blockchain reorganization is required but disabled by --no-reorg flag."); |
heemankv
approved these changes
Nov 21, 2025
apoorvsadana
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information