-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add support for versioned constants in Orchestrator #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohiiit
requested changes
Nov 20, 2025
Member
Mohiiit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of taking the path and then converting the yaml/json file to the versionconstants, we can do something like this:
fn parse_constants(path: &str) -> Result<VersionedConstants, String> {
std::fs::read_to_string(path)
.map_err(|e| e.to_string())
.and_then(|content| {
serde_json::from_str::<VersionedConstants>(&content)
.map_err(|e| e.to_string())
})
}
#[derive(Parser, Debug)]
pub struct Args {
#[arg(
env = "MADARA_ORCHESTRATOR_VERSIONED_CONSTANTS_PATH",
long,
value_parser = parse_constants
)]
pub versioned_constants: Option<VersionedConstants>,
}this way we won't have to add versioned_constants in the ConfigParam and it would be part of the snos_config only and can be used directly then
Mohiiit
requested changes
Nov 21, 2025
Mohiiit
reviewed
Nov 21, 2025
Mohiiit
approved these changes
Nov 21, 2025
apoorvsadana
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information