This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
UI refactoring for better mobile experience #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,7 @@ | |||
| } | |||
| #story-list.no-nav { | |||
| left: 20px; | |||
| margin-left: 3px !important; | |||
There was a problem hiding this comment.
This should go in the media query.
There was a problem hiding this comment.
Makes sense: I've moved that in bf84d67
|
I'm not opposed to making this better, but this PR messes up the non-mobile view quite a bit. Could you change this PR so that the non-mobile view is not affected? |
|
Can you be more specific about how the non-mobile view is affected? I've been using it regularly on Firefox 34. I've also tested more briefly on Safari 8 and Chrome. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI changes tend to be controversial, so I won't take it personally if you hate this and reject it out of hand. I try not to take code personally anyway, but UI changes seem to merit an extra disclaimer.
The existing UI is a little frustrating for me on narrow screens, because it hides almost everything under a utility menu icon. So common actions like refresh takes an extra tap, which feels clumsy. These changes keep refresh, up, and down visible even when the rest of the navbar is hidden. That made the two tabs (about, feeds) look funny, so I pushed them onto the other side of the navbar. Finally I made the app icon act like a second refresh button, which seemed natural to me.