-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: Postmark integration #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
(cherry picked from commit ab1372666e25117d3b68c6acf25694375f5fbde7)
(cherry picked from commit 90019d49519d6ece6d9e220b8353209a4fc4c118)
051a1e0
to
5a33b3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (3)
- apps/admin-x-activitypub/package.json: Language not supported
- ghost/core/config.development.json: Language not supported
- ghost/core/content/themes/casper: Language not supported
Comments suppressed due to low confidence (4)
ghost/postmark-client/lib/PostmarkClient.js:8
- Ensure that PostmarkClient implements all the required functions defined in MailAdapterBase (such as 'send', 'fetchEvents', etc.) to fully satisfy the adapter interface.
module.exports = class PostmarkClient extends MailAdapterBase {
ghost/core/core/server/services/lib/MailgunClient.js:8
- Ensure that MailgunClient implements all the required functions declared by MailAdapterBase in order to comply with the adapter contract.
module.exports = class MailgunClient extends MailAdapterBase {
ghost/core/core/server/services/adapter-manager/index.js:19
- [nitpick] Verify that registering the abstract MailAdapterBase as the mail adapter does not cause issues when resolving concrete implementations; consider whether concrete adapters should be registered instead.
adapterManager.registerAdapter('mail', require('../../adapters/mail/MailAdapterBase'));
ghost/core/core/server/services/email-service/EmailServiceWrapper.js:5
- [nitpick] Confirm that the updated adapterManager.getAdapter call correctly handles all mail provider cases, especially for 'postmark', which was previously explicitly instantiated.
const adapterManager = require('../adapter-manager');
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:all
andyarn lint
)We appreciate your contribution!