Use the adapter to get the email analytics provider #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (2)
- ghost/core/package.json: Language not supported
- ghost/email-analytics-provider-postmark/package.json: Language not supported
Comments suppressed due to low confidence (2)
ghost/postmark-client/lib/PostmarkClient.js:316
- The EmailAnalyticsProviderPostmark constructor has been refactored to only destructure {client, config} yet is still being passed a 'settings' property. Either update the constructor to include 'settings' if needed or remove it from the instantiation to ensure a consistent interface.
settings: this.#settings
ghost/email-analytics-provider-postmark/test/provider-postmark.test.js:1
- The removal of the EmailAnalyticsProviderPostmark test file may reduce test coverage for the new provider implementation. Consider adding tests to verify its behavior under the new adapter-based integration.
describe('EmailAnalyticsProviderPostmark', function () {});
There was a problem hiding this comment.
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (2)
- ghost/core/package.json: Language not supported
- ghost/email-analytics-provider-postmark/package.json: Language not supported
Comments suppressed due to low confidence (1)
ghost/postmark-client/lib/EmailAnalyticsProviderPostmark.js:15
- It appears that the config key is still checking for 'bulkEmail:mailgun:tag' in the Postmark provider. Consider updating this to use a Postmark-specific key (e.g. 'bulkEmail:postmark:tag') if applicable.
if (config.get('bulkEmail:mailgun:tag')) {
3 tasks
nbayramberdiyev
pushed a commit
that referenced
this pull request
Jun 25, 2025
- We keep seeing a flakey failure in the portal tests: ``` FAIL src/tests/SignupFlow.test.js > Signup > as paid member on single tier site > with default settings on monthly plan [2726](https://github.com/TryGhost/Ghost/actions/runs/15649953622/job/44093261730#step:7:2744) TestingLibraryElementError: Found multiple elements with the text: Limited early adopter pricing #7-1749888016395 ``` - This is yet another attempt to fix it: - Eliminates Race Conditions: Using objectId() instead of Date.now() + Math.random() ensures each fixture gets a truly unique identifier - Handles Expected UI Behavior: The test now correctly handles the fact that benefits legitimately appear in multiple places in the UI - More Robust Assertions: Using queryAllByText + waitFor makes the test more resilient to timing issues - Maintains Test Intent: The test still verifies that the benefit text appears in the UI, just more flexibly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
Please check your PR against these items:
We appreciate your contribution! 🙏