Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
dispatch2to use theDispatchRetained<T>pattern instead of types owning the retain count internally. This should allow us to use Dispatch types in the auto-generated headers. See #681 (comment) for why we don't use a more general approach to these*Retainedtypes.I've also decided to prefix types with "Dispatch", to better match Swift, and to allow easily glob-importing from
dispatch2without fear that the symbols will clash with something else. This isn't that "rusty", but it plays much nicer with the rest of theobjc2ecosystem, and matches what Swift does.It's also clearer at the usage-site. Compare:
See #681 for further discussion about this refactor.
Part of #77. Unblocks #710.