Add private registry controls for redis/postgres initContainers #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When redis and/or postgres is enabled, the initContainers used to wait for the availability of these services have hardcoded images/tags. This can lead to policy violations when images must be pulled from a private registry and when explicit tags/digests must be used.
The present PR adds the ability to control the image repository,tag and digest in the same way as is done for the main mageai container, for the standalone deployment, webserver and scheduler. Additionally the digest value is added for all images in the values file, so it is clear it can be configured.
The default values are:
And can be overridden like so:
The following issues are related (the alpine one not exactly since it refers to the testing image): #65 #46
Tests
The following values overrides were used to template the chart with
helm template:And the following can be seen from the output for the scheduler, where both redis and postgres initContainer images are sourced from the private registry, with the redis one using a fixed tag and the postgres one using a digest: