Skip to content

Conversation

@JaysonDeMarchi
Copy link

@JaysonDeMarchi JaysonDeMarchi commented Jan 13, 2021

Description (*)

Set the sourceCode to the default source provider's code by default. The sourceCode attribute is assumed to be populated even though there is no path if a shipment object has no sourceCode and single source mode is not enabled. This can result in an undefined variable error if a feature is not fully accounting for MSI. Ideally this should point to the source with the highest priority, but pointing it at the default source still seems like a better option than pointing it at no source.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Create a shipment object without a sourceCode set.
  2. Setup multiple sources.
  3. Trigger the SourceDeductionProcessor.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Stepa4man
Copy link
Contributor

@magento run all tests

@JaysonDeMarchi
Copy link
Author

@magento run all tests

@Stepa4man
Copy link
Contributor

@JaysonDeMarchi thanks for your contribution.

Please cover your changes with tests. In this way, we can also better understand the problem.

Thanks

@sidolov sidolov changed the base branch from 1.2-develop to develop November 11, 2021 17:48
@engcom-Hotel engcom-Hotel moved this to Review in Progress in Inventory - Pull Request Progress Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

2 participants