Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CartRepositoryInterface.php #39316

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

apedicdev
Copy link
Contributor

@apedicdev apedicdev commented Oct 31, 2024

Given the save() implementation uses \Magento\Quote\Model\QuoteRepository\SaveHandler::save which throws 3 exceptions, I think they also should be declared at interface level

Resolved issues:

  1. resolves [Issue] Update CartRepositoryInterface.php #39328: Update CartRepositoryInterface.php

Given it uses \Magento\Quote\Model\QuoteRepository\SaveHandler::save which throws 3 exception I think they also should be declared at interface level
Copy link

m2-assistant bot commented Oct 31, 2024

Hi @apedicdev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@apedicdev
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Update CartRepositoryInterface.php
2 participants