magento/magento2#39148: xsd validation that contains comments below f…

[Kiraberos]

Description (*)

• Fixed issue with adding string type for the <comment> element.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes xsd validation fails on etc/adminhtml/system.xml files that contain comments below field items. #39148

Manual testing scenarios (*)

1. Launch PHPStorm and configure XSD verification as described in the Magento documentation.
2. Locate a file that contains a <comment> as a child element of a <field>.
3. Verify the XSD validation for <comment> elements under <field> elements in system.xml configuration files.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Kiraberos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Kiraberos]

@magento run all tests

[Kiraberos]

@magento run all tests

[Kiraberos]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests

[engcom-Hotel]

Hello @Kiraberos,

Thank you for your contribution!

It seems the automated tests like Integration, Static and WebApi are failing due to this PR changes. We request you to please fix those.

Thanks

[engcom-Hotel]

Suggested change

	* Copyright 2015 Adobe
	* Copyright 2012 Adobe

[engcom-Dash]

Hello @Kiraberos

Thank you for the contribution!

Before moving forward with the changes on the PR we have tried to reproduce the issue in PhpStrom IDE. However it is not reproducible on 2.4-develop branch. Please find below screenshots.

We have ran the command "bin/magento dev:urn-catalog:generate .idea/misc.xml" to generate urn mappings and configure xsd verification.

After this we have restarted the Phpstorm. Still the comment tag looks fine and rendering without any error.

Are we missing any other configuration to reproduce the issue?

Thank you!

[engcom-Dash]

@Kiraberos Since we are still unable to reproduce the issue on 2.4-develop branch, we are placing this PR on hold for now. Please let us know if you have any additional information that could help us investigate further.

Thank You!

[gwharton]

I was able to reproduce on my development build, a fresh 2.4.8 composer install and 2.4-develop.

One thing I did notice is that PHPStorm will not carry out xsd validation prior to indexing being completed.

[jakwinkler]

This PR can be closed as it does not address all variations of the <comment> node in system.xml
Proper fix is here: #39867