Skip to content

Issue when configure remote storage with prefix issue fixed #39845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

Sathakathulla-S
Copy link

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Issue when configure remote storage with prefix #39294

Manual testing scenarios (*)

  1. https://my-bucket.s3.region.amazonaws.com/media/
  2. Issue fixed.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Sorry, something went wrong.

Copy link

m2-assistant bot commented Apr 19, 2025

Hi @Sathakathulla-S. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Sathakathulla-S
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes incorrect URL concatenation when a storage prefix is configured, ensuring the S3 object URL includes a proper separator before the prefix.

  • Insert a forward slash before the trimmed prefix in AwsS3Factory.
  • Maintain trailing slash after the prefix.
Comments suppressed due to low confidence (1)

app/code/Magento/AwsS3/Driver/AwsS3Factory.php:161

  • When prefix is empty this produces a double slash (//) in the URL. Consider only adding the slash when prefix is non-empty, for example: ($prefix !== '' ? '/' . trim($prefix, '\/') : '').
$objectUrl = rtrim($client->getObjectUrl($config['bucket'], './'), '/') . '/' . trim($prefix, '\/') . '/';

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Sathakathulla-S,

Thank you for the contribution!

Please sign the CLA and also I guess we can add some automated test in accordance to the DOD.

Thanks

@@ -158,7 +158,7 @@ public function createConfigured(
'cache' => $cache
]
);
$objectUrl = rtrim($client->getObjectUrl($config['bucket'], './'), '/') . trim($prefix, '\\/') . '/';
$objectUrl = rtrim($client->getObjectUrl($config['bucket'], './'), '/') . '/' . trim($prefix, '\\/') . '/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When prefix is empty this produces a double slash (//) in the URL. Consider only adding the slash when prefix is non-empty, for example: ($prefix !== '' ? '/' . trim($prefix, '/') : '').

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard May 13, 2025
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

Issue when configure remote storage with prefix
4 participants