-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA-3162-V3::Price filter change in sidebar #4164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glo80771
added
the
version: Minor
This changeset includes functionality added in a backwards compatible manner.
label
Sep 15, 2023
|
glo42707
force-pushed
the
PWA-3162-V3
branch
from
September 27, 2023 14:17
64fd78f
to
6114b61
Compare
glo82145
force-pushed
the
PWA-3162-V3
branch
from
September 27, 2023 14:45
6114b61
to
ed6f434
Compare
glo82145
force-pushed
the
PWA-3162-V3
branch
5 times, most recently
from
March 20, 2024 13:39
70509b7
to
78552e8
Compare
glo82145
approved these changes
Mar 20, 2024
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs triage
pkg:peregrine
pkg:venia-ui
Progress: done
version: Minor
This changeset includes functionality added in a backwards compatible manner.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the event that a different price filter is applied after a price filter is already applied, the query will only be for the first price filter, not the combination of the two.
This behavior might be interpreted as a bug but is actually a mis-implementation of the UI for the price filter which only allows a "range" ie {{
{ "from": "0", "to": "100" }
}}.
Related Issue
Closes https://jira.corp.adobe.com/browse/PWA-3162.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist