Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3170:: price filter showing currency symbol #4173

Merged
merged 11 commits into from
Oct 4, 2023
Merged

PWA-3170:: price filter showing currency symbol #4173

merged 11 commits into from
Oct 4, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Oct 4, 2023

Description

Describe the bug

Is there a reason why the price filter doesn't display the currency symbol? This is something I'm happy to contribute if someone gives me a 👍🏽. It seems too basic that I feel something is blocking this?

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3170

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 4, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 4, 2023

Messages
📖

Associated JIRA tickets: PWA-3170.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 66b3252

@glo82145
Copy link
Collaborator Author

glo82145 commented Oct 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

glo82145 commented Oct 4, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator Author

glo82145 commented Oct 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

glo82145 commented Oct 4, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 6b1c0cb into develop Oct 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants