Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3227::yarn install broken after #4191 #4207

Merged
merged 2 commits into from
Mar 20, 2024
Merged

PWA-3227::yarn install broken after #4191 #4207

merged 2 commits into from
Mar 20, 2024

Conversation

glo80771
Copy link
Contributor

Description

yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

To reproduce

Steps to reproduce the behavior:

run yarn install
Expected behavior

no error

Related Issue

https://jira.corp.adobe.com/browse/PWA-3227.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo80771 glo80771 added version: Patch This changeset includes backwards compatible bug fixes. and removed needs triage labels Nov 29, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 29, 2023

Messages
📖

Associated JIRA tickets: PWA-3227.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against c646e8a

@glo82145
Copy link
Collaborator

run lighthouse-desktop

2 similar comments
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-desktop

dpatil-magento
dpatil-magento previously approved these changes Nov 30, 2023
Copy link
Contributor

@dpatil-magento dpatil-magento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy approval to test ability to merge

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@glo82145 glo82145 merged commit d0eb0a4 into develop Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants