Open
Conversation
Contributor
|
@manishparanjape - Thank you for this submission, it really helped track down some odd symptoms we saw with Fastly in the cloud. These missing headers were not only causing content to not be edge cached, but also broke gzip compression/encoding in the process. While I don't think we want to open up header injection, we do want to enforce this best practice of cache control. We're struggling to think of a use case why this would need to be extensible, but wanted to check with you. Can you think of a reason we shouldn't just append a year long cache-control header if one is not already present? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #52