Date fix + Fix Acronis Cyber Protect Connect + Upgrade PDQ Connect Network Sigma + GitHub Actions on README.md #47
Conversation
magicsword-io#32 According to the Sigma Rules Specification, the date format in Sigma rule files must follow the ISO 8601 standard, using the separator format (YYYY-MM-DD instead of YYYY/MM/DD).
|
Date fix goal is explained here: #32 According to the Sigma Rules Specification, the date format in Sigma rule files must follow the ISO 8601 standard, using the separator format (YYYY-MM-DD instead of YYYY/MM/DD). |
wikijm
changed the title
|
hey @wikijm overall the PR looks great since we want to enforce the date for sigma we probably want to enforce it on our validation python script and job: https://github.com/magicsword-io/LOLRMM/blob/main/.github/workflows/validate.yml#L26 what do you think about this? |
|
Hi @josehelps Excellent idea! |
|
Hi @josehelps Is my help still required? |
|
@wikijm I haven't had a shot to dig into it but if you want to add this as a validation check on this PR to https://github.com/magicsword-io/LOLRMM/blob/main/bin/validate.py that would be amazing, this way we can just run validate make sure all yamls follow this structure for date. |
|
Hi @josehelps I created this pull request based on your suggestion: #70 |
This ensures that the script works for both 'LastModified:' and 'Created:' lines in the .yaml files.
Change yaml directory
|
I took the initiative to relocate the script I created, which addresses issues in the previous YAML files, to the bin folder. |
If you want to avoid using a custom secret, you can utilize the built-in GITHUB_TOKEN, which is automatically provided by GitHub Actions and does not require manual setup.
Update actions/checkout version
Update actions/checkout
No description provided.