fix: AnimatedGridPattern hydration + effect loop + invalid DOM prop#858
Merged
itsarghyadas merged 4 commits intomagicuidesign:mainfrom Jan 12, 2026
Merged
Conversation
|
@Yeom-JinHo is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Dec 28, 2025
Collaborator
Author
|
@dillionverma @itsarghyadas |
530e6e2 to
8bc4612
Compare
Collaborator
|
@Yeom-JinHo merging this PR, looks good. Thanks. |
This was referenced Jan 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #854 #848
Description
This PR focuses on fixing React warnings and hydration issues in the
AnimatedGridPatterncomponent.It also addresses a render loop / maximum update depth issue caused by unstable effect dependencies.
Changes
repeatDelayfrom leaking into the root<svg>via...props, removing the React warning.ResizeObservercleanup withdisconnect().Motivation
repeatDelayon DOM elements).Math.random()).Maximum update depth exceededand make resize handling more robust.Breaking Changes