Introduce simple soil carbon management (scm) option #774

k4rst3ns · 2025-02-07T14:40:16Z

🐦 Description of this PR 🐦

This PR

adds a simple exogenously driven soil carbon management option to the cellpool_jan23 realization.
The old cellpool realization has also been removed as it is outdated.
The working cellpool realization is adapted to work with the changed carbon densities from preprocessing, where forest carbon stocks have higher values as they are only calculated for potential forest areas while clustering and are not over the whole cluster area. As this realisations needs are generic natural reference the stoks provided in other (other land) are used for the generic computation within the som module.

🔧 Checklist for PR creator 🔧

Label pull request from the label list.
- Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
Self-review own code
- No hard coded numbers and cluster/country/region names.
- The new code doesn't contain declared but unused parameters or variables.
- magpie4 R library has been updated accordingly and backwards compatible where necessary.
- still to be done
- scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
Document changes
- Add changes to CHANGELOG.md
- Where relevant, put In-code documentation comments
- Properly address updates in interfaces in the module documentations
- run goxygen::goxygen() and verify the modified code is properly documented
Perform test runs
- Medium risk: -> no default settings changed so individual sets of runs can be found under
  /p/projects/magpie/users/karstens/MAGPIEMODEL/magpie_socm/output with default_0pX_SCM01[_Y]
  with X being the scm target share, and Y additional settings like 1p5 degree goal or nocc runs
Check logs for errors/warnings

Soil Carbon reacts to scm settings the way expected

Cropland shows small reduction effects due to higher costs

Emissions only slightly reacts

🚨 Checklist for reviewer 🚨

PR is labeled correctly
Code changes look reasonable
- No hard coded numbers and cluster/country/region names.
- No unnecessary increase in module interfaces
- model behavior/performance is satisfactory.
Changes are properly documented
- CHANGELOG is updated correctly
- Updates in interfaces have been properly addressed in the module documentations
- In-code documentation looks appropriate
content review done (at least 1)
RSE review done (at least 1)

CHANGELOG.md

bodirsky · 2025-02-14T08:52:59Z

modules/11_costs/default/equations.gms

@@ -32,14 +32,15 @@
                   + vm_cost_timber(i2)
                   + vm_cost_hvarea_natveg(i2)
                   + vm_cost_processing(i2)
+                   + sum(cell(i2,j2), vm_cost_scm(j2))


did you check the cost scripts in magpie4 whether they correctly include these costs? (the magpie4 script sometimes requires a categorization of the costs into one-off investments and yerarly costs)

in case of questions wrt these scripts, you can ask edna or david, i think

no cost not included yet in magpie4 - I will ask for help and commit to magpie4.

When done, please also increase the magpie4 R library version number in the DESC file.

modules/11_costs/default/equations.gms

modules/59_som/cellpool_jan23/declarations.gms

modules/59_som/cellpool_jan23/input.gms

modules/59_som/cellpool_jan23/equations.gms

config/default.cfg

bodirsky

Thanks for addressing my comments.
Fine to merge for me.

Changes in magpie4 library (costs) are still to do.

flohump

Thanks for these improvements.
Looks good overall.
I have some minor comments and requests.
Can you add results for the static_jan19 realisation (current default).
And for overview, it would be great to have global cropland and land-use change CO2 emissions.

flohump · 2025-02-17T09:10:08Z

config/default.cfg

@@ -1807,12 +1807,12 @@ cfg$gms$s58_fix_peatland  <- 2020   # def = 2020

 # ***-------------------------    59_som   -------------------------------------
 # * (static_jan19): static soil carbon loss for cropland
-# * (cellpool_aug16): dynamic soil organic matter pool on cellular level
 # * (cellpool_jan23): dynamic soil organic matter pool on cellular level
 # *                   with updated, regionalized stock change factors (IPCC guidelines 2019)
 cfg$gms$som <- "static_jan19"    # def = static_jan19


Can we make cellpool_jan23 the new default?
This would make the setup of coupled REMIND-MAgPIE runs with SCM much easier.
I guess that with s59_scm_target <- 0 the results are comparable to the current default?

flohump · 2025-02-17T09:11:29Z

modules/11_costs/default/equations.gms

@@ -32,14 +32,15 @@
                   + vm_cost_timber(i2)
                   + vm_cost_hvarea_natveg(i2)
                   + vm_cost_processing(i2)
+                   + sum(cell(i2,j2), vm_cost_scm(j2))


When done, please also increase the magpie4 R library version number in the DESC file.

modules/14_yields/managementcalib_aug19/input.gms

modules/35_natveg/pot_forest_may24/input.gms

flohump · 2025-02-17T09:37:08Z

modules/59_som/cellpool_jan23/equations.gms

@@ -12,7 +12,8 @@

 q59_som_target_cropland(j2) ..
              v59_som_target(j2,"crop")
-              =e= (sum((kcr,w), vm_area(j2,kcr,w) * i59_cratio(j2,kcr,w)) 
+              =e= (sum((kcr,w), vm_area(j2,kcr,w) * i59_cratio(j2,kcr,w)) * 
+                     (1 + sum(ct, i59_scm_target(ct,j2)) * (i59_ratio_scm(j2) - 1)) 


I don't understand i59_ratio_scm(j2) - 1).
Can you add a brief explanation?

Wil change to something like

(sum((kcr,w), vm_area(j2,kcr,w) * i59_cratio(j2,kcr,w)) +
sum((kcr,w), vm_area(j2,kcr,w) * sum(ct, i59_scm_target(ct,j2))
i59_cratio(j2,kcr,w)) * (i59_ratio_scm(j2) - 1))

CHANGELOG.md

tscheypidi · 2025-02-17T09:59:57Z

main.gms

+* 3: In gms::check_config(cfg, extras = c("info", "repositories",  ... :
+*   Config looks different when stored via saveConfig and loaded via loadConfig!
+* 4: In gms::check_config(cfg, extras = c("info", "repositories",  ... :
+*   Config looks different when stored via saveConfig and loaded via loadConfig!


what happened here? There should be no warnings committed to main.gms and we need to check whether the warning indicates a relevant problem here.

main.gms

tscheypidi · 2025-02-17T10:00:27Z

main.gms

@@ -278,7 +288,7 @@ $setglobal awms  ipcc2006_aug16
 $setglobal ghg_policy  price_aug22
 $setglobal maccs  on_aug22
 $setglobal peatland  v2
-$setglobal som  static_jan19
+$setglobal som  cellpool_jan23


non-default setting

modules/14_yields/managementcalib_aug19/input.gms

modules/52_carbon/normal_dec17/input.gms

tscheypidi · 2025-02-17T10:09:08Z

modules/59_som/cellpool_jan23/equations.gms

@@ -12,7 +12,8 @@



perhaps add a sentence to the documentation, that the equilibrium value can be boosted via SCM?

tscheypidi · 2025-02-17T10:11:26Z

modules/59_som/cellpool_jan23/input.gms

 ;

+* The implementation of soil carbon management on cropland refers to a diverse set of  


I am wondering whether this comment should only show up here or should be also part of the in-code documentation.

tscheypidi · 2025-02-17T10:15:02Z

modules/59_som/cellpool_jan23/preloop.gms

+  m_sigmoid_time_interpol(i59_scm_scenario_fader,s59_scm_scenario_start,s59_scm_scenario_target,0,1);
+);
+
+* Country switch to determine countries for which certain policies shall be applied.


looks like the code will still be put into the goxygen documentation, but this comment will not show up as part of the documentation (maybe instead as a comment in the code? I am honestly not sure).

Most likely this should be either also a goxygen comment or the @Stop from line 111 should happen earlier.

please build the documentation and have a look at how it looks (also related to the other comments above)

modules/59_som/static_jan19/input.gms

pvjeetze

Thanks a lot @k4rst3ns for reworking the whole realisation. I only have minor comments to add to the previous comments made by the others.

config/default.cfg

modules/59_som/cellpool_jan23/declarations.gms

pvjeetze · 2025-02-20T15:28:14Z

config/default.cfg

+cfg$gms$s59_fader_functional_form <- 1   # def = 1
+
+# * Sigmoid fader for minimum area share of SCM on total cropland at cluster level
+# * Minimum area share of SCM on total cropland in target year


Maybe consider to add examples of plausible values here.

Co-authored-by: pvjeetze <[email protected]>

k4rst3ns added 3 commits February 6, 2025 11:01

add soil carbon management option to cellpool_jan23 realization

8f78c1a

Merge remote-tracking branch 'origin/develop' into f_socm

02fc506

Merge remote-tracking branch 'origin/develop' into f_socm

64fcb4e

k4rst3ns added enhancement New feature or request Medium risk labels Feb 7, 2025

k4rst3ns added 2 commits February 13, 2025 10:43

Merge remote-tracking branch 'upstream/develop' into f_socm

d5ae396

Update cost estimates, add changelog information

ec0346a

bodirsky requested changes Feb 14, 2025

View reviewed changes

k4rst3ns and others added 4 commits February 14, 2025 23:52

Update literature.bib

c21c4e5

adding documentation to the code

ff95c18

clean some names and description

571ad79

Merge remote-tracking branch 'upstream/develop' into f_socm

04f32cd

k4rst3ns marked this pull request as ready for review February 16, 2025 21:52

k4rst3ns requested review from tscheypidi, flohump and pvjeetze February 16, 2025 22:11

bodirsky approved these changes Feb 17, 2025

View reviewed changes

flohump requested changes Feb 17, 2025

View reviewed changes

tscheypidi requested changes Feb 17, 2025

View reviewed changes

pvjeetze approved these changes Feb 20, 2025

View reviewed changes

k4rst3ns and others added 3 commits March 6, 2025 11:17

redo unwanted changes, small naming issue in som module

f2fa553

Merge remote-tracking branch 'origin/develop' into f_socm

ff32e3f

Update config/default.cfg

f37fd9b

Co-authored-by: pvjeetze <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce simple soil carbon management (scm) option #774

Introduce simple soil carbon management (scm) option #774

k4rst3ns commented Feb 7, 2025 •

edited

Loading

bodirsky Feb 14, 2025

bodirsky Feb 14, 2025

k4rst3ns Feb 16, 2025

flohump Feb 17, 2025

bodirsky left a comment

flohump left a comment

flohump Feb 17, 2025

flohump Feb 17, 2025

flohump Feb 17, 2025

k4rst3ns Feb 27, 2025

tscheypidi Feb 17, 2025

tscheypidi Feb 17, 2025

tscheypidi Feb 17, 2025

tscheypidi Feb 17, 2025

tscheypidi Feb 17, 2025

pvjeetze left a comment

pvjeetze Feb 20, 2025

		;

		* The implementation of soil carbon management on cropland refers to a diverse set of

Introduce simple soil carbon management (scm) option #774

Are you sure you want to change the base?

Introduce simple soil carbon management (scm) option #774

Conversation

k4rst3ns commented Feb 7, 2025 • edited Loading

🐦 Description of this PR 🐦

🔧 Checklist for PR creator 🔧

🚨 Checklist for reviewer 🚨

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bodirsky left a comment

Choose a reason for hiding this comment

flohump left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvjeetze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k4rst3ns commented Feb 7, 2025 •

edited

Loading