Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LUC CO2 emission dynamics #784

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Mar 10, 2025

🐦 Description of this PR 🐦

This PR aims to improve LUC CO2 emission dynamics, especially until 2035.

  • Limit for annual peatland rewetting (2% of degraded peatland per year) to avoid adhoc rewetting of degraded peatlands with introduction of CO2 price.
  • Reactivated external scenario for damage from shifting agriculture (cfg$gms$s35_forest_damage <- 2). This improves LUC CO2 emissions in the near-term in LAM, and partly in SSA.
  • Minimum CO2 price of 1 $ per ton CO2 on emissions from deforestation and other land conversion in all time steps to avoid sudden jumps in carbon stock changes. The impact is visible in RAW CO2 emissions without low pass filter in SSA, LAM and OAS. The minimum CO2 price does not change overall model dynamics. Especially, net forest change is similar with and w/o minimum CO2 price.

Emissions_CO2_Land_RAW_Land_use_Change-12
Emissions_CO2_Land_RAW_Land_use_Change-13
Resources_Land_Cover_Cropland-144
Resources_Land_Cover_Cropland-143
Productivity_Landuse_Intensity_Indicator_Tau-114
Resources_NetForestChange-2
Resources_NetForestChange-3
Resources_Peatland_Degraded-8
Emissions_CO2_Land_RAW_Land_use_Change_Peatland
Costs_Accounting

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

  • Current develop branch default : 31 mins
  • This PR's default : 31 mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

@flohump flohump changed the title F calib Improve LUC CO2 emission dynamics Mar 10, 2025
@flohump flohump added enhancement New feature or request Minor Smaller modifications High risk Higher risk labels Mar 10, 2025
@flohump flohump marked this pull request as ready for review March 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High risk Higher risk Minor Smaller modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants