Skip to content

Conversation

@shuvroroy
Copy link
Member

@shuvroroy shuvroroy commented Nov 20, 2024

This pull request introduces support for PHP 8.4. The changes ensure compatibility with the latest PHP version, allowing the MailerLite PHP SDK to function correctly with PHP 8.4.

Changes

  • Added PHP 8.4 version inside test.yml file to ensure full test compatibility.

@shuvroroy shuvroroy self-assigned this Nov 20, 2024
@shuvroroy shuvroroy marked this pull request as ready for review November 20, 2024 04:00
@johnkelesidis
Copy link
Contributor

need more context for this

rekerta
rekerta previously approved these changes Nov 20, 2024
@rekerta
Copy link
Contributor

rekerta commented Nov 20, 2024

need more context for this

we are trying to see if it will work on the newer version, no?

John is right - @shuvroroy please add a proper pr description

@rekerta rekerta dismissed their stale review November 20, 2024 08:27

waiting for pr description

@shuvroroy shuvroroy requested a review from rekerta November 20, 2024 08:32
@shuvroroy
Copy link
Member Author

PR description is added.

@gaurang404 gaurang404 merged commit 5fcd248 into main Nov 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants