Skip to content

chore: update test & composer for laravel framework 12 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JanVDB2000
Copy link

Upgrade Description
This update adds full compatibility with PHP 8.3 and Laravel 12.

In addition, the test suite has been refactored to remove deprecated usage of named arguments in Pest’s data providers. This change ensures future compatibility with PHPUnit 11, which will no longer support named arguments in data-driven tests.

Summary of changes:
Require PHP ^8.3

Allow illuminate/* dependencies for Laravel ^10.0 || ^11.0 || ^12.0

Update orchestra/testbench for Laravel 12 compatibility

Upgrade pest, pest-plugin-laravel, and related dev tools to latest compatible versions

Refactor Pest tests:

Replaced deprecated named argument syntax in ->with() calls

Injected model factories via closures to ensure forward compatibility with PHPUnit 11

@enricodelazzari
Copy link
Member

Your changes look good, but could you please also update the GitHub Actions workflow to include tests for Laravel 12 and PHP 8.4?

You'll need to add 12.x to the laravel matrix and 8.4 to the php matrix in the .github/workflows/run-tests.yml file.

@JanVDB2000
Copy link
Author

Thanks for the heads-up!

I'll go ahead and update the GitHub Actions workflow to include Laravel 12 and PHP 8.4 in the test matrix.
Appreciate the reminder I'll push the changes shortly.

@JanVDB2000
Copy link
Author

I've now updated the workflow to include Laravel 12 and PHP 8.4 in the test matrix, along with the corresponding Testbench version. Let me know if anything else needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants