fix: skip parsing invalid css in preferUnitlessValues #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids throwing an error in a case where unitless values wouldn't make sense anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where builds failed because
preferUnitlessValues(which is on by default) was throwing an error when encountering invalid inline CSS.There are situations where inline CSS values contain expressions that are meant to be parsed later on, and the user just needs to have them output as they are, for example:
Normally PostCSS, which we use to parse the inline styles so we can remove units like
pxfrom 0-based CSS values likemargin: 0px, will trip on that. This PR ensures it just silently skips it so that it's just output as-is.Fixes #1510.