Skip to content

Restore colour to icons #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Restore colour to icons #816

merged 1 commit into from
May 16, 2025

Conversation

miken32
Copy link
Contributor

@miken32 miken32 commented Jan 15, 2025

When the icons were committed, there was no allowance made for the --color option. Not sure if this was intentional, but having the green/red makes things much easier to see at a glance for me.

When the icons were committed, there was no allowance made for the `--color` option. Not sure if this was intentional, but having the green/red makes things much easier to see at a glance for me.
@miken32
Copy link
Contributor Author

miken32 commented Jan 15, 2025

Also I didn't check into where $cmd is used, but it looks like it's missing a \e[0m reset sequence at the end?

@jmrenouard jmrenouard merged commit 1e0f2ef into major:master May 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants