Closed
Conversation
Owner
|
This is quite a major change. Some of it appears to just be reordering of entities, which adds to the noise and makes it difficult to find the actual changes amongst it. At least one dp has had its type changed, dp 246 has switched from string (as documented in #507 and most likely correct) to integer, although #507 is a bit confused about the purpose of the dp. Changes that affect detection like that will need some evidence with them to convince me that it is a good change. Also other changes that affect entity naming need good justification, as that will affect other users who have the config installed also, so just "I like this name better" is not likely to be enough. |
Owner
|
Closed due to no feedback in 2 months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update of the Ceres plus petfeeder config