Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALS-1820 Route avoid options added and Depart options added #120

Merged
merged 16 commits into from
Jan 18, 2025
Merged

ALS-1820 Route avoid options added and Depart options added #120

merged 16 commits into from
Jan 18, 2025

Conversation

shah279
Copy link
Collaborator

@shah279 shah279 commented Jan 17, 2025

feat: Route avoid options added (uTurn, dirt roads and tunnels)
feat: Depart options added
feat: E2E and unit test cases updated

@shah272728
fix: App should work without no data inside custom.properties file
b7e11a8 
ALS-1884
@shah272728
fix: minimum zoom level update
0e202f4 
ALS-1889
@shah272728
feat: Places popup updated with new information
5e9a00f 
ALS-1885
@shah272728
feat: remove VNM from political view listing
da0bfdf 
ALS-1891
@shah272728
feat: update design on political view
027642c 
ALS-1891
@shah272728
fix: zoom level fix, chinese language name changes and removed unused…
1163283 
… strings

ALS-1889
@shah272728
feat: route avoid options added (uTurn, dirt roads and tunnels)
105b20a 
ALS-1818
@shah272728
feat: depart options added
4692b5c 
ALS-1820
@shah272728
feat:
b7a4842 
- Update routes: support departure time, arrival time, leave now options
- Update routes: show directional steps for the route from the new API

ALS-1820 ALS-1816
@shah272728
test: E2E test case added and Unit test cases added
b6c6348 
ALS-1820
@shah272728
fix: text depart design bug fix
deaf4d6 
ALS-1820
@shah272728
code optimize
f7745ec
@shah272728
fix: language translations
a0c6576
@shah279 shah279 requested a review from olegfilimonov January 17, 2025 10:23
@olegfilimonov
Copy link

3 unit Tests are failing

olegfilimonov
olegfilimonov requested changes Jan 17, 2025
View reviewed changes
Copy link

@olegfilimonov olegfilimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re request once tests are passing

@shah279 shah279 requested a review from olegfilimonov January 17, 2025 14:27
@olegfilimonov olegfilimonov merged commit 6ba80ff into develop Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegfilimonov olegfilimonov Awaiting requested review from olegfilimonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shah279 @olegfilimonov @shah272728