Skip to content

feat: Enable issue comment link copy & smooth scroll to comment #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: preview
Choose a base branch
from
Draft

feat: Enable issue comment link copy & smooth scroll to comment #6750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web/core/components/issues/issue-detail/issue-activity/comments/comment-block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ export const IssueCommentBlock: FC<TIssueCommentBlock> = observer((props) => {

if (!comment) return <></>;
return (
<div className={`relative flex gap-3 ${ends === "top" ? `pb-2` : ends === "bottom" ? `pt-2` : `py-2`}`}>
<div
id={`comment-${commentId}`}
className={`relative flex gap-3 ${ends === "top" ? `pb-2` : ends === "bottom" ? `pt-2` : `py-2`}`}
>
<div className="absolute left-[13px] top-0 bottom-0 w-0.5 bg-custom-background-80" aria-hidden />
<div className="flex-shrink-0 relative w-7 h-7 rounded-full flex justify-center items-center z-[3] bg-gray-500 text-white border border-white uppercase font-medium">
{comment.actor_detail?.avatar_url && comment.actor_detail?.avatar_url !== "" ? (
Expand Down
46 changes: 43 additions & 3 deletions web/core/components/issues/issue-detail/issue-activity/comments/comment-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

import { FC, useEffect, useRef, useState } from "react";
import { observer } from "mobx-react";
import { useRouter, usePathname } from "next/navigation";
import { useForm } from "react-hook-form";
import { Check, Globe2, Lock, Pencil, Trash2, X } from "lucide-react";
import { Check, Globe2, Lock, Pencil, Trash2, X, Link } from "lucide-react";
// plane constants
import { EIssueCommentAccessSpecifier } from "@plane/constants";
// plane editor
Expand All @@ -13,13 +14,14 @@ import { useTranslation } from "@plane/i18n";
// plane types
import { TIssueComment } from "@plane/types";
// plane ui
import { CustomMenu } from "@plane/ui";
import { CustomMenu, TOAST_TYPE, setToast } from "@plane/ui";
// plane utils
import { cn } from "@plane/utils";
// components
import { LiteTextEditor, LiteTextReadOnlyEditor } from "@/components/editor";
// helpers
import { isCommentEmpty } from "@/helpers/string.helper";
import { HIGHLIGHT_CLASS } from "@/components/issues/issue-layouts/utils";
import { copyUrlToClipboard, isCommentEmpty } from "@/helpers/string.helper";
// hooks
import { useIssueDetail, useUser, useWorkspace } from "@/hooks/store";
// components
Expand Down Expand Up @@ -96,15 +98,53 @@ export const IssueCommentCard: FC<TIssueCommentCard> = observer((props) => {
}
}, [isEditing, setFocus]);

useEffect(() => {
const hash = window.location.hash;
if (hash === `#comment-${commentId}`) {
setTimeout(() => {
const element = document.getElementById(`comment-${commentId}`);
if (element) {
element.scrollIntoView({ behavior: "smooth", block: "center" });
element.classList.add(HIGHLIGHT_CLASS);
setTimeout(() => {
element.classList.remove(HIGHLIGHT_CLASS);
}, 2000);
}
}, 100);
}
}, [commentId]);

if (!comment || !currentUser) return <></>;

const pathName = usePathname();
const handleCommentLink = (id: string) => {
let path = pathName;
if (path.startsWith("/")) {
path = path.slice(1);
}
if (path.endsWith("/")) {
path = path.slice(0, -1);
}
const commentUrl = path + `#comment-${id}`;
copyUrlToClipboard(commentUrl).then(() =>
setToast({
type: TOAST_TYPE.SUCCESS,
title: "Link copied",
message: "Comment link copied to clipboard",
})
);
};
return (
<IssueCommentBlock
commentId={commentId}
quickActions={
<>
{!disabled && currentUser?.id === comment.actor && (
<CustomMenu ellipsis closeOnSelect>
<CustomMenu.MenuItem onClick={() => handleCommentLink(commentId)} className="flex items-center gap-1">
<Link className="flex-shrink-0 size-3" />
{t("common.actions.copy_link")}
</CustomMenu.MenuItem>
<CustomMenu.MenuItem onClick={() => setIsEditing(true)} className="flex items-center gap-1">
<Pencil className="flex-shrink-0 size-3" />
{t("common.actions.edit")}
Expand Down