feat(translations): add Korean translation #6755
Conversation
Co-authored-by: NavyStack <[email protected]> Co-authored-by: FVOCI <[email protected]>
Co-authored-by: NavyStack <[email protected]> Co-authored-by: FVOCI <[email protected]>
|
|
WalkthroughThis pull request adds support for the Korean language across the internationalization module. It updates the language constant, type definitions, and translation store logic to handle Korean ("ko") while also providing a new translations file. Additionally, the pull request updates string delimiters in one of the translation hooks, switching from single to double quotes without affecting functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant T as TranslationConsumer
participant TS as TranslationStore
participant L as Language Loader
U->>T: Set language to "ko"
T->>TS: Request translation file for "ko"
TS->>L: Import "../locales/ko/translations.json"
L-->>TS: Return Korean translations
TS-->>T: Deliver translations to consumer
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/i18n/src/locales/ko/translations.json (3)
1-20: Review: Sidebar Translations Check
The translations for the sidebar navigation (e.g. "projects", "pages", "new_work_item", etc.) are clear, natural, and consistent with standard Korean UI terminology. One minor suggestion is to double‑check that the term “intake” translated as “접수” perfectly reflects the intended context of the application.
503-510: Review: Pluralization & Interpolation Formats
Several keys use ICU message formatting (for example,"member": "{count, plural, one{# 멤버} other{# 멤버}}"and"resend_in": "{seconds}초 후 다시 전송"). These formats are correctly implemented. Please verify that any regional nuances in plural forms (if needed in future iterations) are handled, though the current identical output for singular and plural cases seems acceptable.
1-2372: Review: Overall Consistency and Completeness
This new Korean translations file is very comprehensive and well‑organized. All major UI components—including navigation, authentication, notifications, settings, dashboards, and more—are covered with translations that adhere to a polite, formal tone and follow common Korean UI conventions. The structure is clear and the use of nesting (for categorizing related keys) aids in maintainability. There are no evident syntax issues in the JSON format, and the use of interpolation placeholders and ICU syntax is consistent across the file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/hooks/use-translation.ts(2 hunks)packages/i18n/src/locales/ko/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)
🔇 Additional comments (8)
packages/i18n/src/constants/language.ts (1)
14-14: Excellent addition of Korean language support!The integration of Korean language with the proper label "한국어" and value "ko" aligns correctly with the internationalization standards.
packages/i18n/src/store/index.ts (1)
156-157: Korean language support properly integratedThe implementation correctly adds a case for handling Korean translations, maintaining consistency with the existing pattern for other languages.
packages/i18n/src/hooks/use-translation.ts (2)
1-1: Consistent quote style changeThe modification of string delimiters from single quotes to double quotes in import statements helps maintain a consistent coding style throughout the codebase.
Also applies to: 3-3, 5-5
26-26: Quote style consistency maintainedConsistent application of double quotes in the error message aligns with the pattern established in the import statements.
packages/i18n/src/types/language.ts (1)
1-1: Type definition correctly updated for Korean languageThe TLanguage type has been properly extended to include "ko" for Korean, ensuring type safety across the application when working with the newly added language.
packages/i18n/src/locales/ko/translations.json (3)
22-91: Review: Authentication & Account Management Translations
The "auth" section—including email, password, and related error messages and placeholders—uses a formal and polite tone. The labels such as "비밀번호", "비밀번호 설정", and error messages like "이메일이 필요합니다" appear accurate and user‑friendly.
92-134: Review: Sign Up and Sign In Sections
The sign‑up and sign‑in sections are translated consistently and provide clear step‑by‑step instructions. The headers, sub‑headers, and guidance messages (e.g. for "가입", "로그인 또는 가입") follow natural Korean usage while maintaining the formal register as per the guidelines.
135-161: Review: Password Recovery & Reset Translations
The keys for "forgot_password", "reset_password", and "set_password" employ concise and polite language. The descriptions like "비밀번호 재설정" and "계정 보호" clearly instruct users on how to recover or change their passwords.
sriramveeraghanta
changed the base branch from
preview
to
feat-core-translations
sriramveeraghanta
merged commit 75aae3b
into
makeplane:feat-core-translations
* feat(translations): add Korean translation (#6755) * feat(translations): init Korean translation Co-authored-by: NavyStack <[email protected]> Co-authored-by: FVOCI <[email protected]> * feat(translations): add rough Korean translation Co-authored-by: NavyStack <[email protected]> Co-authored-by: FVOCI <[email protected]> --------- Co-authored-by: FVOCI <[email protected]> * feat(translations): add Slovak, Deutsch, Ukrainian and Polish translation (#6743) * feat(translation): add Slovak translation * feat(translation): add Slovak translation for workspace * feat(translation): improved Slovak translation for views * feat(translation): add Deutsch translation * feat(translation): add Ukrainian translation * feat(translation): add Polish translation --------- Co-authored-by: sriram veeraghanta <[email protected]> * fix: project cycle translations * fix: build error * feat: Add zh-TW Traditional Chinese locale (#6764) Co-authored-by: sriram veeraghanta <[email protected]> * chore: zh-TW core translation updated --------- Co-authored-by: NavyStack <[email protected]> Co-authored-by: FVOCI <[email protected]> Co-authored-by: Ján Regeš <[email protected]> Co-authored-by: sriram veeraghanta <[email protected]> Co-authored-by: Peter Dave Hello <[email protected]>
Description
This PR introduces Korean translations for UI labels used across the application.
It ensures consistency, improves readability, and aligns with common Korean UI conventions.
Translation Guidelines
1. Prioritising natural translation over word-for-word conversion
Korean translations focus on fluency rather than direct word-for-word accuracy.
For example:
"Your account"→"나의 계정"2. Maintaining polite and formal language
Korean UI texts generally adopt a polite tone.
For example:
"Forgot your password?"→"비밀번호를 잊으셨나요?"-셨나요?is an honorific form, enhancing user-friendliness.3. Avoiding direct second-person pronouns ("You")
Unlike English, Korean UI rarely uses direct second-person pronouns ("You"). Instead, sentences are restructured.
For example:
"Your workspace"→"작업 공간"(instead of"너의 작업 공간")4. Using functional and role-based translations
Translations prioritise clarity and align with standard terminology in development and project management.
For example:
"Work Items"→"작업 항목"Key Changes
✅ Added Korean translations to
ko/translations.json, based onen/translations.json.✅ Ensured all keys were translated with no missing entries (automated validation passed).
✅ Adjusted direct translations to improve readability and contextual accuracy.
Consistency Check
To maintain a uniform translation approach, key terms were consistently translated:
Concerns & Review Requests
1. Phrases that may feel unnatural in Korean
"Good morning"and"Good afternoon"were translated as"좋은 아침"and"좋은 오후", respectively.2. Contextual Accuracy in UI
"Sign in"is translated as"로그인", but"Sign in to your account"is adapted as"내 계정에 로그인"for clarity.📌 Reviewers, please confirm whether the translations feel natural within the UI.
📌 Feedback on any awkward or inconsistent expressions would be greatly appreciated.
Thank you! 🙏🚀
Additional Notes
1. Translation Scope
Currently, only the Community Edition has been translated into Korean.
For translations of other versions, please reach out individually for further discussion.
2. Development Environment Issues
Due to persistent 502 errors from the next build process, fine-tuning is completely blocked at this stage
This issue has significantly impacted progress, and further adjustments will be required once the environment stabilises.
Thank you for your understanding.
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
N/A
Summary by CodeRabbit