[WEB-3826] feat: estimate activitites #6937
Conversation
WalkthroughThe changes update the handling of estimate point activities in both backend and frontend components. On the backend, the field name for issue estimate activities is now dynamically constructed based on the estimate type, rather than using a static value. On the frontend, the activity field name checked in the UI is updated from singular to plural, aligning with the backend change. Additionally, a minor stylistic adjustment was made in the frontend code's destructuring syntax. No changes were made to public interfaces or exported entity signatures. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Frontend
participant Backend
User->>Frontend: Update estimate point
Frontend->>Backend: Send estimate update
Backend->>Backend: Create IssueActivity with dynamic field (e.g., "estimate_story")
Backend-->>Frontend: Respond with activity data
Frontend->>Frontend: Render IssueEstimateActivity if field matches "estimate_points"
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx (1)
42-42: Empty object destructuring could be removed.The empty object destructuring for
commentdoesn't seem to serve any purpose. Consider removing it if not needed.- comment: { }, + // Remove if not used🧰 Tools
🪛 Biome (1.9.4)
[error] 42-42: Unexpected empty object pattern.
(lint/correctness/noEmptyPattern)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apiserver/plane/bgtasks/issue_activities_task.py(1 hunks)web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx(2 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx
[error] 42-42: Unexpected empty object pattern.
(lint/correctness/noEmptyPattern)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx (1)
63-63:Details
❓ Verification inconclusive
Update to plural form matches backend changes.
The case name has been updated from
estimate_pointtoestimate_pointsto match the dynamic field naming in the backend. This ensures proper rendering of estimate-related activities.Let's verify that the backend consistently generates the field name with the correct type:
🏁 Script executed:
#!/bin/bash # Look for field constructions for estimate activities rg -A 5 -B 5 'field="estimate_' --include '*.py'Length of output: 492
Backend Field Naming Update Verification: Please Re-run Corrected Search Command
The update to
"estimate_points"appears correct to align with backend changes. However, our initial automated search failed due to the unsupported--includeflag. To proceed, please re-run the verification with the corrected command—for example:Then manually verify that the backend consistently constructs fields using the
"estimate_points"naming convention.
🏁 Script executed:
#!/bin/bash # Look for field constructions for estimate activities using the proper file filter rg -A 5 -B 5 'field="estimate_' -g '*.py'Length of output: 2223
Action: Verify Backend Field Naming Consistency
The frontend update to change the case from
"estimate_point"to"estimate_points"inactivity-list.tsxhas been applied as intended. However, our verification of the backend code shows that:
- In
apiserver/plane/bgtasks/issue_activities_task.py, there is a check usingrequested_data.get("estimate_point")and a dynamic construction with"estimate_" + new_estimate.estimate.type.- In the migration file
apiserver/plane/db/migrations/0067_issue_estimate.py, references to the singular"estimate_point"are still present.Please manually verify that the backend now consistently generates and returns the plural form (
"estimate_points") where expected. If the backend should indeed use the plural naming, further adjustments to the backend code might be required.
|
@sangeethailango Please add type hints to the |
sangeethailango
changed the title
|
Pull Request Linked with Plane Work Items
Comment Automatically Generated by Plane |
Description
This PR will change estimate activity's field dynamically based on the type.
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References