Instant actions #96
Instant actions #96
Conversation
| // to be performed via an instant access module. This function is called | ||
| // during the `schedule()` call, once the spell has achieved the hat. | ||
| // These functions will not be limited by the officeHours modifier. | ||
| function instantActions() public virtual {} |
There was a problem hiding this comment.
Wondering if would be better to define it without empty implementation so we we make sure to always overwrite it by an empty one in the spell action being deployed.
There was a problem hiding this comment.
We do them so rarely that I didn't want to force it into every spellaction.
| @@ -40,6 +40,8 @@ import {DssAutoLine} from "dss-auto-line/DssAutoLine.sol"; | |||
| import {LerpFactory} from "dss-lerp/LerpFactory.sol"; | |||
| import {DssDirectDepositAaveDai} | |||
| from "dss-direct-deposit/DssDirectDepositAaveDai.sol"; | |||
| import {AaveMock} from "./fixtures/AaveMock.sol"; | |||
| import {DirectDepositMom} from "dss-direct-deposit/DirectDepositMom.sol"; | |||
There was a problem hiding this comment.
D3M repo won't be able to be imported here anymore as it is using solc 0.8.x. We will need to find another way to test D3M stuff.
| @@ -282,6 +286,14 @@ library DssExecLib { | |||
| function setAuthority(address _base, address _authority) public { | |||
| Authorizable(_base).setAuthority(_authority); | |||
| } | |||
| /** | |||
| @dev Deactivates a module with a disable function | |||
There was a problem hiding this comment.
Consider adding other mom-related breaker pattern instant actions (e.g. osm-mom stop, clipper-mom setBreaker, ...).
|
@brianmcmichael It seems we should resolve merging conflicts before proceeding with another run of reviews. |
instantActions()function to DssExec.instantActions()is called inschedule()and enables the use of IAM calls in a DssExec spell.disable(address)function to DssExecLib.