Chitter-challenge #210
Open
Chitter-challenge #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leigh-Rose
reviewed
Apr 4, 2022
Leigh-Rose
reviewed
Apr 4, 2022
| @@ -84,6 +84,7 @@ GEM | |||
|
|
|||
| PLATFORMS | |||
| x86_64-darwin-20 | |||
| x86_64-darwin-21 | |||
There was a problem hiding this comment.
Line 87 interesting, what does this do?
Leigh-Rose
reviewed
Apr 4, 2022
| result = connection.exec("INSERT INTO peeps (message) VALUES('#{message}') RETURNING id, message") | ||
| Peep.new(id: result[0]['id'], message: result[0]['message']) | ||
| end | ||
| end |
Leigh-Rose
reviewed
Apr 4, 2022
| connection = PG.connect(dbname: 'chitter_test') | ||
| result = connection.query("SELECT * FROM peeps WHERE id = #{id};") | ||
| result.first | ||
| end |
Leigh-Rose
reviewed
Apr 4, 2022
|
|
||
| expect(page).to have_content 'This is another peep' | ||
| end | ||
| end |
Leigh-Rose
reviewed
Apr 4, 2022
|
|
||
| expect(page).to have_content 'This is a peep!' | ||
| end | ||
| end |
Leigh-Rose
reviewed
Apr 4, 2022
| connection = PG.connect(dbname: 'chitter') | ||
| end | ||
|
|
||
| result = connection.exec("INSERT INTO peeps (message) VALUES('#{message}') RETURNING id, message") |
There was a problem hiding this comment.
Line 32 could be open to SQL injection attack.
Leigh-Rose
reviewed
Apr 4, 2022
| <%= peep.message %> | ||
| </li> | ||
| <% end %> | ||
| </ul> |
Leigh-Rose
reviewed
Apr 4, 2022
| <form action="/peeps" method="post"> | ||
| <input type="text" name="message" /> | ||
| <input type="submit" name="Submit" /> | ||
| </form> |
siellsiell
reviewed
Apr 12, 2022
Comment on lines
10
to
12
| get '/test' do | ||
| 'Test page' | ||
| end |
There was a problem hiding this comment.
It's always a good idea to remove test code from code you submit for code review (anywhere, not just at Makers)
| erb :"peeps/index" | ||
| end | ||
|
|
||
| get '/peeps/new' do |
There was a problem hiding this comment.
Nice use of RESTful route names!
Comment on lines
+26
to
+30
| if ENV['ENVIRONMENT'] == 'test' | ||
| connection = PG.connect(dbname: 'chitter_test') | ||
| else | ||
| connection = PG.connect(dbname: 'chitter') | ||
| end |
There was a problem hiding this comment.
This piece of code appears twice in this file. How might you remove this duplication?
Comment on lines
+13
to
+16
| expect(peeps.length).to eq 2 | ||
| expect(peeps.first).to be_a Peep | ||
| expect(peeps.first.id).to eq peep.id | ||
| expect(peeps.first.message).to eq 'This is a peep!' |
There was a problem hiding this comment.
Ideally you'd check that both results in the array are correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
Shannon White
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!