Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new fork to fix clone error #225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PhilipCarr1
Copy link

Your name

Please write your full name here to make it easier to find your pull request.

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • User story 1: "I want to see all the messages (peeps) in a browser"
  • User story 2: "I want to post a message (peep) to chitter"
  • User story 3: "I want to see the date the message was posted"
  • User story 4: "I want to see a list of peeps in reverse chronological order"
  • User story 5: "I want to filter on a specific keyword"

README checklist

Does your README contains instructions for

  • how to install,
  • how to run,
  • and how to test your code?

Here is a pill that can help you write a great README!

configure :development do
register Sinatra::Reloader
end

get '/test' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this

@@ -0,0 +1,7 @@
require './lib/database_connection'

if ENV['ENVIRONMENT'] == 'test'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extraction

@tomfuller
Copy link

Really nice neat solution, well done! The only thing I would say is it would be great if you could complete the checklist in the README and and include the instructions to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants